Skip to content

Conversation

@nwmac
Copy link
Member

@nwmac nwmac commented Oct 30, 2025

Summary

Fixes #15797

Occurred changes and/or fixed issues

With some changes to support scalability, we no longer fetch all mgmt clusters in the UI early on.

It turns out that the cluster edit page for the local cluster (when loaded via page refresh) has a bug where it assumes the mgmt cluster information is available.

This PR fixes this bug.

Technical notes summary

Although the cluster edit page fetches the mgmt clusters, there is code in the data method which calculates subType. Unfortunately, data runs before fetch, so if the mgmt clusters have not already been loaded, then the data method will incorrectly calculate subType.

The fix is easy - move the calculation of subType from the data method to fecth. This ensures it occurs after the mgmt clusters have been fetched.

Areas or cases that should be tested

Go the cluster edit page for the local cluster.

Hit refresh on the browser.

Make sure you get the Vue page and not the Ember page.

Screenshot/Video

Vue screen that you should now see:

image

Ember screen that is shown on refresh before the fix in this PR:

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.13.0 milestone Oct 30, 2025
@nwmac nwmac marked this pull request as ready for review October 31, 2025 09:15
@nwmac nwmac requested a review from aalves08 October 31, 2025 09:17
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nwmac nwmac merged commit 605e874 into rancher:master Oct 31, 2025
65 of 67 checks passed
@nwmac nwmac deleted the fix-local-cluster-edit-on-refresh branch October 31, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User lands on Ember UI when refreshing local cluster edit page

2 participants